Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: hostname missing #587

Merged
merged 4 commits into from
Jun 24, 2020
Merged

Fix: hostname missing #587

merged 4 commits into from
Jun 24, 2020

Conversation

thewahome
Copy link
Collaborator

Overview

Makes the graph url an optional parameter so that shared queries from documentation do not fail.
Fixes #571

URL encodes the url to maintain all parts of the shared query
Only shares a hashed request body when a request body exists
Fixes #567

Demo

N/A

Notes

N/A

Testing Instructions

  • Run a complex query
  • Click share query
  • Notice that the query is encoded

@thewahome thewahome merged commit 9717c8c into dev Jun 24, 2020
@thewahome thewahome deleted the fix/hostname-missing branch July 21, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HostName missing on link from documentation page. Share Link doesn't URLENCODE the request URL
2 participants