Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: support different content types #814

Merged
merged 9 commits into from
Feb 3, 2021

Conversation

thewahome
Copy link
Collaborator

@thewahome thewahome commented Jan 27, 2021

Overview

Partially fixes #626
Now successfully supports HTML responses.

Demo

Request: https://graph.microsoft.com/v1.0/me/onenote/pages/{pages-id}/content

Before
image

After
image

Notes

I can not conclusively say that it fixes #626 since I have not been able to test any call that returns an edm.stream response. It errors out with a 403, which is weird since I already have the required permission consented to.

image

Testing Instructions

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-814.centralus.azurestaticapps.net

1 similar comment
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-814.centralus.azurestaticapps.net

@jobala
Copy link
Contributor

jobala commented Jan 27, 2021

I can not conclusively say that it fixes #626 since I have not been able to test any call that returns an edm.stream response. It errors out with a 403, which is weird since I already have the required permission consented to.

@thewahome you can create an issue to track edm.stream responses separately so that we don't stop tracking it once you merge this in.

jobala
jobala previously approved these changes Jan 27, 2021
@jobala
Copy link
Contributor

jobala commented Jan 27, 2021

Not sure how useful to the user showing html is, what do you guys think for previewing the HTML? @thewahome @ddyett ?

@jobala jobala dismissed their stale review January 27, 2021 13:04

Discussion might get lost if the PR gets merged.

@thewahome
Copy link
Collaborator Author

Not sure how useful to the user showing html is, what do you guys think for previewing the HTML? @thewahome @ddyett ?

Could be a good idea... We could go for a split screen for code and preview.

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-814.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2021

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-814.centralus.azurestaticapps.net

@ddyett
Copy link

ddyett commented Feb 2, 2021

Not sure how useful to the user showing html is, what do you guys think for previewing the HTML? @thewahome @ddyett ?

Could be a good idea... We could go for a split screen for code and preview.

should open an issue to track rendering the html

@thewahome
Copy link
Collaborator Author

Not sure how useful to the user showing html is, what do you guys think for previewing the HTML? @thewahome @ddyett ?

Could be a good idea... We could go for a split screen for code and preview.

should open an issue to track rendering the html

Done. #826

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2021

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-814.centralus.azurestaticapps.net

@thewahome thewahome merged commit ccd8702 into dev Feb 3, 2021
ElinorW added a commit that referenced this pull request Feb 16, 2021
* Fix: support different content types (#814)

* Feature: Add Adaptive cards  JSON Schema code (#828)

* Feature: samples testing (#833)

* Feature: Adds 'Report an Issue' menu option (#834)

* Feature: clickable links on message bar (#835)

* fix: intermittent create page error (#837)

* Fix: Add 'Maximize sidebar' aria-label (#842)

* Task: upgrade technologies (#844)

* Fix: expand maxWidth allow more humanName chars (#764)

* Fix: autocomplete options not displaying (#847)

* fix: adaptive cards destroy (#848)

* Fix: Graph Explorer link colors (#846)

* Fix: Adaptive cards instrumentation (#849)

* Fix: adjust column width (#850)

* Task: prevent storing access token (#851)

Co-authored-by: jobala <japhethobalak@gmail.com>
Co-authored-by: Charles Wahome <thewahome.cw@gmail.com>
Co-authored-by: OfficeGlobal <47977325+OfficeGlobal@users.noreply.github.com>
Co-authored-by: OfficeGlobal <OfficeGlobal@microsoft.com>
Co-authored-by: Azure Static Web Apps <opensource@microsoft.com>
Co-authored-by: Millicent Achieng <achieng.milli@gmail.com>
Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com>
Co-authored-by: Ezrqn Kemboi <ezrqnkemboi@gmail.com>
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
Co-authored-by: Joseph Ngugi <jngugi88@gmail.com>
Co-authored-by: Maggie Kimani <maggiekim42@gmail.com>
@thewahome thewahome deleted the fix/support-different-contentTypes branch February 17, 2021 11:36
ElinorW added a commit that referenced this pull request Feb 22, 2021
* Fix: support different content types (#814)

* Feature: Add Adaptive cards  JSON Schema code (#828)

* Feature: samples testing (#833)

* Feature: Adds 'Report an Issue' menu option (#834)

* Feature: clickable links on message bar (#835)

* fix: intermittent create page error (#837)

* HB of localized GE.jsons (#830)

* Fix: Add 'Maximize sidebar' aria-label (#842)

* Task: upgrade technologies (#844)

* Fix: expand maxWidth allow more humanName chars (#764)

* Fix: autocomplete options not displaying (#847)

* fix: adaptive cards destroy (#848)

* Fix: Graph Explorer link colors (#846)

* Fix: Adaptive cards instrumentation (#849)

* Fix: adjust column width (#850)

* Task: prevent storing access token (#851)

* HB of localized GE.jsons (#854)

* chore(release): 4.3.0 (#857)

* Fix: rename component name (#859)

* chore(release): 4.4.0

Co-authored-by: jobala <japhethobalak@gmail.com>
Co-authored-by: Charles Wahome <thewahome.cw@gmail.com>
Co-authored-by: OfficeGlobal <47977325+OfficeGlobal@users.noreply.github.com>
Co-authored-by: OfficeGlobal <OfficeGlobal@microsoft.com>
Co-authored-by: Azure Static Web Apps <opensource@microsoft.com>
Co-authored-by: Millicent Achieng <achieng.milli@gmail.com>
Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com>
Co-authored-by: Ezrqn Kemboi <ezrqnkemboi@gmail.com>
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
Co-authored-by: Joseph Ngugi <jngugi88@gmail.com>
Co-authored-by: Maggie Kimani <maggiekim42@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support all different content types and fallback to showing text
3 participants