-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try-it button opens a blank window in some concept topics in Microsoft Graph docs #843
Comments
I had a chat offline with @angelgolfer-ms |
The experimental fix to make the permissions optional failed |
There are two types of pages:
The technical difference with the pages that's related to this task is that Concept pages do not have a permissions block.
The work of the permissions property was historically to help in authentication with the required scopes. We do not require this now since we have the scope consent functionality. The lack of a permissions block in a Concept page causes a failure in the logic that loads the iframe that houses Graph Explorer. Thus the work here is for the docs team to remove the functionality to get the permissions altogether and pass an empty array into the IInitMessage contract. Thus this:
Should change to:
|
The docs team has agreed to tackle the problem and has created a work-item here. We will close this once they are done. |
Describe the bug
Try-it button appears in some concept topics in Microsoft Graph docs but opens a blank window, like enable online meeting in Outlook, share or delegate calendar.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
If the snippet tool enables the try-it capability in a concept topic (inserts the ```msgraph-interactive tag) and inserts the try-it button for an example REST request, then clicking the button should open Graph Explorer side-by-side on the right pane in the browser.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
![Blank try-it pane in concept topic](https://user-images.githubusercontent.com/12191822/107622259-77c8fc80-6c0c-11eb-89a9-a6741c6909d0.jpg)
Add any other context about the problem here.
AB#8114
The text was updated successfully, but these errors were encountered: