Fix: Graph Explorer link colors #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewahome
requested changes
Feb 12, 2021
| @@ -133,6 +133,7 @@ class AdaptiveCard extends Component<IAdaptiveCardProps> { | |||
| target='_blank' | |||
| rel='noopener noreferrer' | |||
| tabIndex={0} | |||
| style={queryResponseStyles(getTheme()).link} | |||
There was a problem hiding this comment.
We should use the classnames instead
|
@ElinorW does this solve color contrast issue when using the high contrast theme? |
thewahome
reviewed
Feb 12, 2021
| @@ -18,7 +18,7 @@ export const queryResponseStyles = (theme: ITheme) => { | |||
| alignItems: 'center', | |||
| }, | |||
| link: { | |||
| color: theme.palette.blue, | |||
| color: theme.palette.themeDarkAlt, | |||
There was a problem hiding this comment.
Noticed here that themeDarkAlt is applied, while the blueMid value was changed in the theme files. Does this still work?
There was a problem hiding this comment.
Wow, so I think I missed that I had changed the blueMid. Actually, I shall use the blueMid instead of the themeDarkAlt colour
thewahome
reviewed
Feb 12, 2021
src/types/adaptivecard.ts
Outdated
| @@ -15,4 +15,5 @@ export interface IAdaptiveCardProps { | |||
| getAdaptiveCard: Function; | |||
| }; | |||
| queryStatus?: any; | |||
| styles?: object; | |||
There was a problem hiding this comment.
This should not be necessary since messages/theme/style are passed down automatically
thewahome
approved these changes
Feb 15, 2021
ElinorW
added a commit
that referenced
this pull request
Feb 16, 2021
* Fix: support different content types (#814) * Feature: Add Adaptive cards JSON Schema code (#828) * Feature: samples testing (#833) * Feature: Adds 'Report an Issue' menu option (#834) * Feature: clickable links on message bar (#835) * fix: intermittent create page error (#837) * Fix: Add 'Maximize sidebar' aria-label (#842) * Task: upgrade technologies (#844) * Fix: expand maxWidth allow more humanName chars (#764) * Fix: autocomplete options not displaying (#847) * fix: adaptive cards destroy (#848) * Fix: Graph Explorer link colors (#846) * Fix: Adaptive cards instrumentation (#849) * Fix: adjust column width (#850) * Task: prevent storing access token (#851) Co-authored-by: jobala <japhethobalak@gmail.com> Co-authored-by: Charles Wahome <thewahome.cw@gmail.com> Co-authored-by: OfficeGlobal <47977325+OfficeGlobal@users.noreply.github.com> Co-authored-by: OfficeGlobal <OfficeGlobal@microsoft.com> Co-authored-by: Azure Static Web Apps <opensource@microsoft.com> Co-authored-by: Millicent Achieng <achieng.milli@gmail.com> Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com> Co-authored-by: Ezrqn Kemboi <ezrqnkemboi@gmail.com> Co-authored-by: Vincent Biret <vibiret@microsoft.com> Co-authored-by: Joseph Ngugi <jngugi88@gmail.com> Co-authored-by: Maggie Kimani <maggiekim42@gmail.com>
ElinorW
added a commit
that referenced
this pull request
Feb 22, 2021
* Fix: support different content types (#814) * Feature: Add Adaptive cards JSON Schema code (#828) * Feature: samples testing (#833) * Feature: Adds 'Report an Issue' menu option (#834) * Feature: clickable links on message bar (#835) * fix: intermittent create page error (#837) * HB of localized GE.jsons (#830) * Fix: Add 'Maximize sidebar' aria-label (#842) * Task: upgrade technologies (#844) * Fix: expand maxWidth allow more humanName chars (#764) * Fix: autocomplete options not displaying (#847) * fix: adaptive cards destroy (#848) * Fix: Graph Explorer link colors (#846) * Fix: Adaptive cards instrumentation (#849) * Fix: adjust column width (#850) * Task: prevent storing access token (#851) * HB of localized GE.jsons (#854) * chore(release): 4.3.0 (#857) * Fix: rename component name (#859) * chore(release): 4.4.0 Co-authored-by: jobala <japhethobalak@gmail.com> Co-authored-by: Charles Wahome <thewahome.cw@gmail.com> Co-authored-by: OfficeGlobal <47977325+OfficeGlobal@users.noreply.github.com> Co-authored-by: OfficeGlobal <OfficeGlobal@microsoft.com> Co-authored-by: Azure Static Web Apps <opensource@microsoft.com> Co-authored-by: Millicent Achieng <achieng.milli@gmail.com> Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com> Co-authored-by: Ezrqn Kemboi <ezrqnkemboi@gmail.com> Co-authored-by: Vincent Biret <vibiret@microsoft.com> Co-authored-by: Joseph Ngugi <jngugi88@gmail.com> Co-authored-by: Maggie Kimani <maggiekim42@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes some link colours on GE to meet the colour-contrast ratio in dark mode.
Fixes #707
Demo
Testing Instructions