Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Adaptive cards changes #873

Merged
merged 6 commits into from
Mar 3, 2021
Merged

Fix: Adaptive cards changes #873

merged 6 commits into from
Mar 3, 2021

Conversation

ElinorW
Copy link
Collaborator

@ElinorW ElinorW commented Mar 2, 2021

Overview

  • Renamed tab from JSON Schema to JSON template.
  • Modified the message that appears to 'Get started with adaptive cards on Adaptive Cards Templating SDK and experiment on Adaptive Cards designer.'
  • Displays the template payload, without the actual card values.

Fixes #865

Demo

image

@ElinorW ElinorW requested a review from thewahome March 2, 2021 14:49
thewahome
thewahome reviewed Mar 2, 2021
View reviewed changes
src/app/services/actions/adaptive-cards-action-creator.ts Outdated
Comment on lines 88 to 89
const card = template.expand(context);
return card;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be returned immediately without the need to declare it

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2021

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-873.centralus.azurestaticapps.net

@ElinorW ElinorW merged commit f225fe4 into dev Mar 3, 2021
@ElinorW ElinorW deleted the fix/adaptive-cards-changes branch March 3, 2021 08:44
thewahome added a commit that referenced this pull request Mar 3, 2021
@thewahome
chore(release): 4.4.1 (#878)
8190568 
* Fix: autocomplete-onfocusout (#855)

* Feature: make paging easier (#861)

* Fix: metadata syntax highlighting (#864)

* Fix: Adaptive cards changes (#873)

* Fix: snippets not available (#877)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewahome thewahome thewahome approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Additional changes on the Adaptive cards tab
2 participants
@ElinorW @thewahome