Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] groupId filter for React people picker #1510

Closed
PathToSharePoint opened this issue Feb 4, 2022 · 5 comments
Closed

[BUG] groupId filter for React people picker #1510

PathToSharePoint opened this issue Feb 4, 2022 · 5 comments
Labels
bug Something isn't working Needs: Triage 🔍
Milestone

Comments

@PathToSharePoint
Copy link

Describe the bug
I am using the MGT people picker in combination with the group filter.

component: PeoplePicker, props: { className: mgtTheme, groupId: this.properties.mgtGroupPicker, selectionMode: "single", type: PersonType.person, defaultSelectedUserIds: [this.properties.mgtPeoplePicker], selectionChanged: (e: any) => { let users = []; console.log(e.detail); e.detail.forEach(dtl => users.push(dtl.userPrincipalName)); this.updateWebPartProperty("mgtPeoplePicker", users[0]); } }

For groupId I use the GUID of the group.

If I start typing, the filter works as expected and the picker only displays names that both contain the letters and belong to the group.

However, if I just click on the people picker, it displays 6 names and I can pick any of them even if the person doesn't belong to the group.

To Reproduce
Steps to reproduce the behavior:

  1. Import the people picker component
    import { PeoplePicker } from '@microsoft/mgt-react'
  2. Add it to the React solution, incuding a groupId prop
  3. Click on the people picker box
  4. See 6 people listed, not necessarily from the group.

Expected behavior
I would expect the choices to be restricted to only people in the group.
Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

  • SPFx React
@PathToSharePoint PathToSharePoint added bug Something isn't working Needs: Triage 🔍 labels Feb 4, 2022
@ghost
Copy link

ghost commented Feb 4, 2022

Hello PathToSharePoint, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@PathToSharePoint
Copy link
Author

PathToSharePoint commented Feb 5, 2022

Screenshots of the issue: I have also posted the sample.

- Before typing (incorrect list):

- After typing "M" (correct, non-matching profiles don't show up)

@sebastienlevert
Copy link
Contributor

Similar to #1471. We're looking into it!

@sebastienlevert sebastienlevert added this to the Future milestone Feb 7, 2022
@PathToSharePoint
Copy link
Author

Thanks for the follow up @sebastienlevert . And for me in 2.3.2, the group filter seems to work as soon as I type a letter.

@sebastienlevert
Copy link
Contributor

Duplicate of #1471, closing this one, tracking the work in the other one.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Needs: Triage 🔍
Projects
Archived in project
Development

No branches or pull requests

2 participants