fix: properly validate typed in emails and set them on comma or semi-colon key presses #1978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this._setAnyMail property is used to check if the comma or semi-colon have been pressed. If they have, then the typed email is checked if it is a valid email and set accordingly.
|
Thank you for creating a Pull Request @musale. This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:
|
musale
force-pushed
the
musale/fix-allow-anymail
branch
from
6bbdd31
to
641c9ad
Compare
|
The updated storybook is available here |
3 similar comments
|
The updated storybook is available here |
|
The updated storybook is available here |
|
The updated storybook is available here |
gavinbarron
reviewed
Dec 8, 2022
packages/mgt-components/src/components/mgt-people-picker/mgt-people-picker.ts
Show resolved
Hide resolved
|
When typing an email, I can't make it "selected" by tapping enter or whatever. This needs to be fixed. |
I have fixed this. So, setting an email is done when you press comma, semi-colon or enter keys. |
|
The updated storybook is available here |
1 similar comment
|
The updated storybook is available here |
gavinbarron
approved these changes
Dec 13, 2022
packages/mgt-components/src/components/mgt-people-picker/mgt-people-picker.ts
Show resolved
Hide resolved
|
The updated storybook is available here |
gavinbarron
approved these changes
Dec 15, 2022
This was referenced Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1970
PR Type
Description of the changes
RegExfor validating emails to this https://www.emailregex.comthis._setAnyEmailto check whether the comm or semi-colon keys have been pressed. If truthy, then set the any email typed if it is valid.internalPropertytostate.PR checklist
yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense)Other information