-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a11y): set aria-expanded for mgt-login when open/closed #2405
Conversation
fix: ensure login pop-up renders inside window
Thank you for creating a Pull Request @gavinbarron. This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:
|
The updated storybook is available here |
The updated storybook is available here |
The updated storybook is available here |
The updated storybook is available here |
The updated storybook is available here |
Hi @musale, This issue is partially fixed as it is working as per the expected result but for the observation related issue, Screen reader is still not announcing the information about the email id. Test Environment: Attachment: MGTP.-.Issue.is.partially.fixed.mp4 |
Closes #2269
Closes #2354
PR Type
Description of the changes
Sets the aria-expanded attribute of the button rendered when a user is signed in
Fixes the positioning of the pop-up when the button is on the right of the screen and is narrower than the pop-up
PR checklist
yarn build
) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense
)Other information