Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): set aria-expanded for mgt-login when open/closed #2405

Merged
merged 5 commits into from
Jun 7, 2023

Conversation

gavinbarron
Copy link
Member

Closes #2269
Closes #2354

PR Type

  • Bugfix

Description of the changes

Sets the aria-expanded attribute of the button rendered when a user is signed in

Fixes the positioning of the pop-up when the button is on the right of the screen and is narrower than the pop-up

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • Accessibility tested and approved
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

fix: ensure login pop-up renders inside window
@gavinbarron gavinbarron requested a review from a team as a code owner June 5, 2023 23:48
@ghost
Copy link

ghost commented Jun 5, 2023

Thank you for creating a Pull Request @gavinbarron.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

The updated storybook is available here

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

The updated storybook is available here

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

The updated storybook is available here

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

The updated storybook is available here

@musale musale enabled auto-merge (squash) June 7, 2023 11:27
@musale musale merged commit d084665 into next/fluentui Jun 7, 2023
8 checks passed
@musale musale deleted the fix/login-expanded-and-right-align branch June 7, 2023 11:35
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

The updated storybook is available here

@vagpt
Copy link
Collaborator

vagpt commented Jun 7, 2023

Hi @musale,

This issue is partially fixed as it is working as per the expected result but for the observation related issue, Screen reader is still not announcing the information about the email id.

Test Environment:
URL: https://mgt.dev/next/pr/2405/?path=/story/samples-general--localization
OS Version: 23H2(OS Build 25381.1)
Browser Version: Version 115.0.1880.3 (Official build) dev (64-bit)
Screen Reader: Narrator

Attachment:

MGTP.-.Issue.is.partially.fixed.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
4 participants