Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add InAConferenceCall activity when availability is Busy #2585

Merged
merged 9 commits into from
Jul 14, 2023
Merged

fix: add InAConferenceCall activity when availability is Busy #2585

merged 9 commits into from
Jul 14, 2023

Conversation

musale
Copy link
Contributor

@musale musale commented Jul 4, 2023

Closes #2583

PR Type

  • Bugfix

Description of the changes

Adds InAConferenceCall activity when availability is Busy

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@musale
Add InAConferenceCall activity when availability is busy
a9d97e1 
Signed-off-by: Martin Musale <martinmusale@microsoft.com>
@musale musale requested a review from a team as a code owner July 4, 2023 11:50
@ghost
Copy link

ghost commented Jul 4, 2023

Thank you for creating a Pull Request @musale.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

The updated storybook is available here

1 similar comment
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

The updated storybook is available here

Mnickii
Mnickii previously approved these changes Jul 4, 2023
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

The updated storybook is available here

@musale
Set default values for activity
8f50776 
Signed-off-by: Martin Musale <martinmusale@microsoft.com>
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

The updated storybook is available here

Mnickii and others added 2 commits July 13, 2023 15:59
@Mnickii @gavinbarron
include OutOfOffice defaults
262751d 
Co-authored-by: Gavin Barron <gavinbarron@microsoft.com>
@Mnickii @gavinbarron
include busy activities in default case
19a0e98 
Co-authored-by: Gavin Barron <gavinbarron@microsoft.com>
@github-actions
Copy link

The updated storybook is available here

1 similar comment
@github-actions
Copy link

The updated storybook is available here

@github-actions
Copy link

The updated storybook is available here

@gavinbarron gavinbarron enabled auto-merge (squash) July 14, 2023 18:52
@gavinbarron gavinbarron merged commit bd17195 into main Jul 14, 2023
7 checks passed
@gavinbarron gavinbarron deleted the add-in-conf-availability branch July 14, 2023 19:02
@github-actions
Copy link

The updated storybook is available here

This was referenced Jul 17, 2023
Closed
Closed
Merged
gavinbarron added a commit that referenced this pull request Aug 21, 2023
@musale @Mnickii @gavinbarron
fix: add InAConferenceCall activity when availability is Busy (#2585
7e7038a 
)

Add InAConferenceCall activity when availability is busy
Set default values for activity

---------

Signed-off-by: Martin Musale <martinmusale@microsoft.com>
Co-authored-by: Nickii Miaro <miaronkirote@gmail.com>
Co-authored-by: Gavin Barron <gavinbarron@microsoft.com>
@gavinbarron gavinbarron mentioned this pull request Oct 10, 2023
Merged
@gavinbarron gavinbarron mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mnickii Mnickii Mnickii left review comments

@gavinbarron gavinbarron gavinbarron approved these changes

Assignees
No one assigned
Labels
Build: Storybook
Projects
Graph Toolkit
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Presence Icon wrong when a user's presence is availability: Busy, activity: InAConferenceCall
3 participants
@musale @gavinbarron @Mnickii