Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds pointer cursor to mgt-login logged in accounts #2674

Merged
merged 3 commits into from Aug 22, 2023
Merged

Conversation

Mnickii
Copy link
Collaborator

@Mnickii Mnickii commented Aug 21, 2023

Closes #2647

PR Type

Bugfix

Description of the changes

provides a cursor for logged in accounts in mgt-login

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@Mnickii Mnickii requested a review from a team as a code owner August 21, 2023 14:14
@microsoft-github-policy-service
Copy link
Contributor

Thank you for creating a Pull Request @Mnickii.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@Mnickii Mnickii changed the title fix: adds pointer cursor to logged in accounts fix: adds pointer cursor to mgt-login logged in accounts Aug 21, 2023
@musale musale merged commit 14cc8fd into main Aug 22, 2023
7 checks passed
@musale musale deleted the bug-2647 branch August 22, 2023 13:53
gavinbarron pushed a commit that referenced this pull request Aug 25, 2023
Co-authored-by: Musale Martin <martinmusale@microsoft.com>
gavinbarron added a commit that referenced this pull request Oct 3, 2023
)

* fix accessibility contrast

* fix placeholder hover

* remove login changes

* adds pointer cursor to logged in accounts (#2674)

Co-authored-by: Musale Martin <martinmusale@microsoft.com>

* fix build

* change picker-text-color

* update picker color, update file theme colors

* fix people picker colors, remove file-list box shadow

* change placeholder color

---------

Co-authored-by: Musale Martin <martinmusale@microsoft.com>
Co-authored-by: Gavin Barron <gavinbarron@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] mgt-login doesn't provide a hover cursor for other logged in accounts
3 participants