Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set custom css token --default-font-family to apply to all elements in DOM #2677

Merged
merged 1 commit into from Aug 25, 2023

Conversation

Mnickii
Copy link
Collaborator

@Mnickii Mnickii commented Aug 23, 2023

Closes #2641

PR Type

Bugfix

Description of the changes

Removes setting --default-font-family on a per element basis
Applies --default-font-family to all elements in DOM

PR checklist

  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@Mnickii Mnickii requested a review from a team as a code owner August 23, 2023 12:22
@microsoft-github-policy-service
Copy link
Contributor

Thank you for creating a Pull Request @Mnickii.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@github-actions
Copy link

The updated storybook is available here

1 similar comment
@github-actions
Copy link

The updated storybook is available here

Copy link
Contributor

@musale musale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on this @Mnickii! Are we also giving defaults for the other font properties like size etc?

@gavinbarron
Copy link
Member

@musale looks like there is the ability to set a default font size in this PR.
If you have suggestions for other global defaults let's capture them in a separate work item.

Copy link
Member

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @Mnickii!

@Mnickii Mnickii merged commit d898d98 into main Aug 25, 2023
8 checks passed
@Mnickii Mnickii deleted the bug-2641 branch August 25, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Docs] How to customize font being used
3 participants