Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MgtProfile): Fix handling of null values for educations & work positions #2717

Conversation

chaelli
Copy link
Contributor

@chaelli chaelli commented Sep 13, 2023

Closes #2713

PR Type

  • Bugfix

Description of the changes

Added some null/undefined handling to not show invalid data:
Old:
image

New:
image

this is for a case where an education has no programm displayName and startdate. It also fixes the issue when the startdate ist 0001-01-01 which is obviously also invalid.
It also removes the ',' when no state or no city is given in a work position.

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • Stories have been added and existing stories have been tested
  • Contains NO breaking changes

@chaelli chaelli requested a review from a team as a code owner September 13, 2023 09:22
@microsoft-github-policy-service
Copy link
Contributor

Thank you for creating a Pull Request @chaelli.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

Copy link
Member

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @chaelli
There's a few small changes I'd like for this to get merged

@chaelli
Copy link
Contributor Author

chaelli commented Sep 15, 2023 via email

Copy link
Member

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thank you @chaelli

@gavinbarron gavinbarron merged commit ba381c8 into microsoftgraph:main Sep 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Schools and education entered in Delve will always lead to a Bachelors Degree in 1970
3 participants