Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure batch url resources start with / #2740

Merged
merged 3 commits into from Sep 27, 2023
Merged

Conversation

gavinbarron
Copy link
Member

Closes #2739

PR Type

  • Bugfix

Description of the changes

fixes incorrect conditional change in #2731 at

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@gavinbarron gavinbarron requested a review from a team as a code owner September 27, 2023 20:52
@gavinbarron gavinbarron changed the title Fix/batch url issue fix: ensure batch url resources start with / Sep 27, 2023
@gavinbarron gavinbarron merged commit 247f37a into main Sep 27, 2023
7 checks passed
@gavinbarron gavinbarron deleted the fix/batch-url-issue branch September 27, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] $batch queries are losing the first segment from the URL path
2 participants