Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initials rendering in mgt-person #2764

Merged
merged 4 commits into from Oct 6, 2023
Merged

Conversation

gavinbarron
Copy link
Member

Closes #2763

PR Type

  • Bugfix

Description of the changes

Adds tests and correct checks to ensure that we don't attempt to read into a nullish or empty string value.

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@gavinbarron gavinbarron requested a review from a team as a code owner October 6, 2023 18:23
@gavinbarron gavinbarron changed the title Fix/initials rendering fix: initials rendering in mgt-person Oct 6, 2023
@gavinbarron gavinbarron enabled auto-merge (squash) October 6, 2023 18:24
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

🚀 New react-contoso sample application deployed here

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

🚀 New react-contoso sample application deployed here

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

📖 The updated storybook is available here

@gavinbarron gavinbarron merged commit 882aaf6 into main Oct 6, 2023
12 checks passed
@gavinbarron gavinbarron deleted the fix/initials-rendering branch October 6, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] mgt-person breaks when a user type is supplied but the given/sunames are null
2 participants