Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add space to filters template string in people-filters #2826

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

Mnickii
Copy link
Collaborator

@Mnickii Mnickii commented Nov 3, 2023

Closes #2738

PR Type

Bugfix

Description of the changes

add space to filters template string in people-filters

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@Mnickii Mnickii requested a review from a team as a code owner November 3, 2023 10:55
Copy link

github-actions bot commented Nov 3, 2023

📖 The updated storybook is available here

1 similar comment
Copy link

github-actions bot commented Nov 3, 2023

📖 The updated storybook is available here

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback Issue needs response from issue author label Nov 3, 2023
Copy link

github-actions bot commented Nov 3, 2023

📖 The updated storybook is available here

Copy link

github-actions bot commented Nov 6, 2023

📖 The updated storybook is available here

Copy link

github-actions bot commented Nov 6, 2023

📖 The updated storybook is available here

Copy link

github-actions bot commented Nov 6, 2023

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 81% 100% 0
mgt-components.src.components.mgt-contact 68% 83% 0
mgt-components.src.components.mgt-file 51% 100% 0
mgt-components.src.components.mgt-file-list 56% 100% 0
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 88% 0
mgt-components.src.components.mgt-messages 66% 100% 0
mgt-components.src.components.mgt-organization 47% 100% 0
mgt-components.src.components.mgt-person 79% 65% 0
mgt-components.src.components.mgt-person-card 64% 38% 0
mgt-components.src.components.mgt-profile 40% 100% 0
mgt-components.src.components.mgt-theme-toggle 100% 100% 0
mgt-components.src.components.sub-components.mgt-flyout 72% 53% 0
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0
mgt-components.src.graph 38% 89% 0
mgt-components.src.styles 92% 80% 0
mgt-components.src.utils 79% 28% 0
mgt-element.dist.es6.components.src.components 73% 79% 0
mgt-element.dist.es6.mock.src.mock 90% 67% 0
mgt-element.dist.es6.providers.src.providers 85% 69% 0
mgt-element.dist.es6.src 91% 80% 0
mgt-element.dist.es6.utils.src.utils 66% 69% 0
mgt-element.src 88% 100% 0
mgt-element.src.components 84% 100% 0
mgt-element.src.mock 81% 56% 0
mgt-element.src.providers 80% 85% 0
mgt-element.src.utils 71% 90% 0
Summary 65% (12446 / 19095) 63% (401 / 634) 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build: Storybook Needs: Author Feedback Issue needs response from issue author
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] mgt-people-picker: Invalid $filter when using people-filters
3 participants