feat: require explicit component registration #2848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
all components must now be registered by developers to ensure that they render a convenience registeration function of registerMgtComponents can register all components mgt-loader registers all components when loading the underlying scripts into the browser BREAKING CHANGE: Developers must explicitly call the register function for all components used in their application. Importing from the root of @microsoft/mgt-components no longer has an automatic registration side effect
|
Thank you for creating a Pull Request @gavinbarron. This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:
|
|
🚀 New react-contoso sample application deployed here |
|
|
🚀 New react-contoso sample application deployed here |
|
📖 The updated storybook is available here |
sebastienlevert
approved these changes
Nov 13, 2023
|
📖 The updated storybook is available here |
1 similar comment
|
📖 The updated storybook is available here |
This was referenced Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
PR Type
Description of the changes
all components must now be registered by developers to ensure that they render a convenience registeration function of registerMgtComponents can register all components mgt-loader registers all components when loading the underlying scripts into the browser
BREAKING CHANGE: Developers must explicitly call the register function for all components used in their application. Importing from the root of @microsoft/mgt-components no longer has an automatic registration side effect.
PR checklist
yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense)BEGIN_COMMIT_OVERRIDE
feat!: require explicit component registration (#2848)
all components must now be registered by developers to ensure that they render
a convenience registeration function of registerMgtComponents can register all components
mgt-loader registers all components when loading the underlying scripts into the browser
BREAKING CHANGE: Developers must explicitly call the register function for all web components used in their application when using components from
@microsoft/mgt-components. Importing from the root of@microsoft/mgt-componentsno longer has an automatic registration side effect. NOTE Components from@microsoft/mgt-reactwill automatically register the underlying web component when they are used for the first time.END_COMMIT_OVERRIDE