-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update person details when mgt-person attributes are changed #2871
Conversation
🚀 New react-contoso sample application deployed here |
1 similar comment
🚀 New react-contoso sample application deployed here |
📖 The updated storybook is available here |
1 similar comment
📖 The updated storybook is available here |
🚀 New react-contoso sample application deployed here |
📖 The updated storybook is available here |
🚀 New react-contoso sample application deployed here |
📖 The updated storybook is available here |
🚀 New react-contoso sample application deployed here |
📖 The updated storybook is available here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The adding of the @state
decorators got me to go do some reading and spot a significant change between versions 1, 2, and 3 of lit around how requestUpdate
works, so that was a change that I don't want us to pursue, but one that has helped us by making us learn more
packages/mgt-components/src/components/mgt-person/mgt-person.ts
Outdated
Show resolved
Hide resolved
🚀 New react-contoso sample application deployed here |
📖 The updated storybook is available here |
packages/mgt-components/src/components/mgt-person/mgt-person.ts
Outdated
Show resolved
Hide resolved
🚀 New react-contoso sample application deployed here |
📖 The updated storybook is available here |
🚀 New react-contoso sample application deployed here |
📖 The updated storybook is available here |
|
Closes #2831
PR Type
Bugfix
Description of the changes
Update mgt-person user details when attributes are changed
PR checklist
yarn build
) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense
)Other information