Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update person details when mgt-person attributes are changed #2871

Merged
merged 6 commits into from
Dec 11, 2023

Conversation

Mnickii
Copy link
Collaborator

@Mnickii Mnickii commented Nov 22, 2023

Closes #2831

PR Type

Bugfix

Description of the changes

Update mgt-person user details when attributes are changed

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

Copy link

🚀 New react-contoso sample application deployed here

1 similar comment
Copy link

🚀 New react-contoso sample application deployed here

Copy link

📖 The updated storybook is available here

1 similar comment
Copy link

📖 The updated storybook is available here

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback Issue needs response from issue author label Nov 22, 2023
Copy link

🚀 New react-contoso sample application deployed here

Copy link

📖 The updated storybook is available here

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback Issue needs response from issue author label Nov 23, 2023
Copy link

🚀 New react-contoso sample application deployed here

Copy link

📖 The updated storybook is available here

musale
musale previously approved these changes Nov 23, 2023
Copy link

github-actions bot commented Dec 1, 2023

🚀 New react-contoso sample application deployed here

Copy link

github-actions bot commented Dec 1, 2023

📖 The updated storybook is available here

Copy link
Member

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The adding of the @state decorators got me to go do some reading and spot a significant change between versions 1, 2, and 3 of lit around how requestUpdate works, so that was a change that I don't want us to pursue, but one that has helped us by making us learn more

Copy link

github-actions bot commented Dec 4, 2023

🚀 New react-contoso sample application deployed here

Copy link

github-actions bot commented Dec 4, 2023

📖 The updated storybook is available here

@Mnickii Mnickii dismissed stale reviews from musale and sebastienlevert via 0554796 December 7, 2023 06:57
Copy link

github-actions bot commented Dec 7, 2023

🚀 New react-contoso sample application deployed here

Copy link

github-actions bot commented Dec 7, 2023

📖 The updated storybook is available here

Copy link

github-actions bot commented Dec 7, 2023

🚀 New react-contoso sample application deployed here

Copy link

github-actions bot commented Dec 7, 2023

📖 The updated storybook is available here

Copy link

github-actions bot commented Dec 7, 2023

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 80% 100% 0
mgt-components.src.components.mgt-contact 63% 100% 0
mgt-components.src.components.mgt-file 51% 100% 0
mgt-components.src.components.mgt-file-list 56% 100% 0
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 88% 0
mgt-components.src.components.mgt-get 30% 100% 0
mgt-components.src.components.mgt-messages 66% 100% 0
mgt-components.src.components.mgt-organization 47% 100% 0
mgt-components.src.components.mgt-person 81% 65% 0
mgt-components.src.components.mgt-person-card 64% 50% 0
mgt-components.src.components.mgt-picker 78% 100% 0
mgt-components.src.components.mgt-profile 40% 100% 0
mgt-components.src.components.mgt-tasks-base 77% 100% 0
mgt-components.src.components.mgt-theme-toggle 100% 100% 0
mgt-components.src.components.mgt-todo 79% 100% 0
mgt-components.src.components.sub-components.mgt-arrow-options 71% 100% 0
mgt-components.src.components.sub-components.mgt-flyout 78% 53% 0
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0
mgt-components.src.graph 38% 89% 0
mgt-components.src.styles 92% 80% 0
mgt-components.src.utils 79% 19% 0
mgt-element.dist.es6.components.src.components 73% 80% 0
mgt-element.dist.es6.mock.src.mock 91% 73% 0
mgt-element.dist.es6.providers.src.providers 85% 72% 0
mgt-element.dist.es6.src 91% 80% 0
mgt-element.dist.es6.utils.src.utils 66% 69% 0
mgt-element.src 88% 100% 0
mgt-element.src.components 78% 100% 0
mgt-element.src.mock 81% 56% 0
mgt-element.src.providers 80% 85% 0
mgt-element.src.utils 71% 90% 0
Summary 66% (14072 / 21429) 64% (411 / 644) 0

@Mnickii Mnickii requested a review from musale December 11, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] Unable to change user-id
4 participants