Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add optional person-card to people picker #2900

Merged
merged 21 commits into from Jan 26, 2024
Merged

feat: add optional person-card to people picker #2900

merged 21 commits into from Jan 26, 2024

Conversation

Mnickii
Copy link
Collaborator

@Mnickii Mnickii commented Dec 5, 2023 •
edited

Closes #1940
Closes #2903

PR Type

Feature

Description of the changes

Add optional person-card to people-picker
Fixes theme colors

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR: here
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

🚀 New react-contoso sample application deployed here

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

📖 The updated storybook is available here

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

📖 The updated storybook is available here

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

📖 The updated storybook is available here

@sebastienlevert
Copy link
Contributor

When using the current state, this seems a bit problematic:

image

@Mnickii Mnickii marked this pull request as ready for review December 7, 2023 06:58
@Mnickii Mnickii requested a review from a team as a code owner December 7, 2023 06:58
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

🚀 New react-contoso sample application deployed here

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

📖 The updated storybook is available here

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

🚀 New react-contoso sample application deployed here

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

📖 The updated storybook is available here

@sebastienlevert
Copy link
Contributor

Something weird is happening here. The Sandbox URL is now wrong when using this PR. Did we make changes to the way we build or to the way we use this value? Also, the fallback value is not working anymore I think, it should be https://graph.office.net/en-us/graph/api/proxy?url=

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback Issue needs response from issue author label Dec 11, 2023
@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

sebastienlevert
sebastienlevert requested changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@sebastienlevert sebastienlevert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a missing Docs PR for this attribute that is being added.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback Issue needs response from issue author label Jan 24, 2024
@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback Issue needs response from issue author label Jan 25, 2024
@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

@gavinbarron gavinbarron enabled auto-merge (squash) January 25, 2024 20:19
@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

1 similar comment
@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 85% 67% 0 ✔
mgt-components.src.components.mgt-contact 63% 100% 0 ➖
mgt-components.src.components.mgt-file 62% 100% 0 ➖
mgt-components.src.components.mgt-file-list 46% 100% 0 ❌
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 86% 0 ❌
mgt-components.src.components.mgt-get 22% 100% 0 ❌
mgt-components.src.components.mgt-messages 68% 100% 0 ➖
mgt-components.src.components.mgt-organization 47% 100% 0 ❌
mgt-components.src.components.mgt-person 78% 65% 0 ✔
mgt-components.src.components.mgt-person-card 50% 65% 0 ❌
mgt-components.src.components.mgt-picker 80% 100% 0 ✔
mgt-components.src.components.mgt-profile 40% 100% 0 ❌
mgt-components.src.components.mgt-tasks-base 87% 100% 0 ✔
mgt-components.src.components.mgt-theme-toggle 100% 100% 0 ✔
mgt-components.src.components.mgt-todo 79% 100% 0 ✔
mgt-components.src.components.sub-components.mgt-flyout 72% 53% 0 ➖
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0 ✔
mgt-components.src.graph 38% 86% 0 ❌
mgt-components.src.styles 92% 80% 0 ✔
mgt-components.src.utils 78% 11% 0 ✔
mgt-element.dist.es6.components.src.components 72% 73% 0 ➖
mgt-element.dist.es6.mock.src.mock 91% 77% 0 ✔
mgt-element.dist.es6.providers.src.providers 83% 69% 0 ✔
mgt-element.dist.es6.src 90% 100% 0 ✔
mgt-element.dist.es6.utils.src.utils 63% 72% 0 ➖
mgt-element.src 93% 40% 0 ✔
mgt-element.src.components 78% 100% 0 ✔
mgt-element.src.mock 81% 56% 0 ✔
mgt-element.src.providers 83% 91% 0 ✔
mgt-element.src.utils 71% 90% 0 ➖
Summary 64% (13729 / 21438) 64% (379 / 589) 0 ➖

@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

@gavinbarron gavinbarron merged commit 65ca8e2 into main Jan 26, 2024
14 checks passed
@gavinbarron gavinbarron deleted the feat-1940 branch January 26, 2024 09:03
This was referenced Jan 26, 2024
Merged
Closed
@gavinbarron gavinbarron linked an issue Jan 30, 2024 that may be closed by this pull request
[BUG] - Alignment of details lines in Person component is no longer centered when using a large profile photo #2976
Closed
This was referenced Jan 30, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinbarron gavinbarron gavinbarron approved these changes

@sebastienlevert sebastienlevert sebastienlevert approved these changes

@musale musale Awaiting requested review from musale

Assignees
No one assigned
Labels
Build: React Contoso Build: Storybook
Projects
Graph Toolkit
Archived in project
Milestone
No milestone
4 participants
@Mnickii @sebastienlevert @musale @gavinbarron