Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add focus on input field when you click the button to add a new task #2994

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

musale
Copy link
Contributor

@musale musale commented Jan 30, 2024

Closes #2291

PR Type

  • Bugfix

Description of the changes

Sets the add new task input to autofocus when you click/activate the add button.

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@musale musale added this to the v4.1.0 milestone Jan 30, 2024
@musale musale requested a review from a team as a code owner January 30, 2024 14:08
Copy link

📖 The updated storybook is available here

1 similar comment
Copy link

📖 The updated storybook is available here

Copy link
Member

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love how simple this fix is, great work @musale

@gavinbarron
Copy link
Member

@vagpt I believe that this resolves the linked issue. Could you please confirm

Copy link

github-actions bot commented Feb 1, 2024

📖 The updated storybook is available here

@vagpt
Copy link
Collaborator

vagpt commented Feb 2, 2024

Hi @gavinbarron and @musale

Could you please confirm us whether UI has been changed for the Task as We are not getting 'mgt-task' option in the URL provided here.

image

@sebastienlevert
Copy link
Contributor

sebastienlevert commented Feb 2, 2024

@vagpt It is now called mgt-planner. The component name was updated to reflect better the scenarios it delivers.

@vagpt
Copy link
Collaborator

vagpt commented Feb 2, 2024

@vagpt It is now called mgt-planner. The component name was updated to reflect better the scenarios it delivers.

Thanks @sebastienlevert for the help and quick response.

This issue is now working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[MGTP- Mgt-tasks - tasks]: After activating 'Add' button keyboard focus is not landing on the desired control.
5 participants