Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add detail-line part attribute to person component #2999

Merged
merged 10 commits into from
Feb 2, 2024

Conversation

Mnickii
Copy link
Collaborator

@Mnickii Mnickii commented Jan 30, 2024

Closes #2975

PR Type

Bugfix

Description of the changes

Adds detail-line part attribute for customization

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

Copy link

📖 The updated storybook is available here

3 similar comments
Copy link

📖 The updated storybook is available here

Copy link

📖 The updated storybook is available here

Copy link

📖 The updated storybook is available here

@sebastienlevert
Copy link
Contributor

This looks like this for me: I'm expecting to see an ellipsis, right?

image

Copy link
Member

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please have a story that shows using the detail-line part to style them?

@gavinbarron
Copy link
Member

This looks like this for me: I'm expecting to see an ellipsis, right?

image

did you set the --person-details-wrapper-width css prop?

Copy link

📖 The updated storybook is available here

Copy link

🚀 New react-contoso sample application deployed here

Copy link

📖 The updated storybook is available here

Copy link

github-actions bot commented Feb 1, 2024

🚀 New react-contoso sample application deployed here

Copy link

github-actions bot commented Feb 1, 2024

📖 The updated storybook is available here

musale
musale previously approved these changes Feb 2, 2024
Copy link

github-actions bot commented Feb 2, 2024

🚀 New react-contoso sample application deployed here

Copy link

github-actions bot commented Feb 2, 2024

📖 The updated storybook is available here

gavinbarron
gavinbarron previously approved these changes Feb 2, 2024
Copy link
Member

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks @Mnickii

@gavinbarron gavinbarron enabled auto-merge (squash) February 2, 2024 17:34
Copy link

github-actions bot commented Feb 2, 2024

🚀 New react-contoso sample application deployed here

Copy link

github-actions bot commented Feb 2, 2024

📖 The updated storybook is available here

@gavinbarron gavinbarron dismissed stale reviews from musale and themself via ffe2cb6 February 2, 2024 19:27
Copy link

github-actions bot commented Feb 2, 2024

🚀 New react-contoso sample application deployed here

Copy link

github-actions bot commented Feb 2, 2024

📖 The updated storybook is available here

Copy link

github-actions bot commented Feb 2, 2024

🚀 New react-contoso sample application deployed here

Copy link

github-actions bot commented Feb 2, 2024

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 85% 67% 0
mgt-components.src.components.mgt-contact 63% 100% 0
mgt-components.src.components.mgt-file 62% 100% 0
mgt-components.src.components.mgt-file-list 46% 100% 0
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 86% 0
mgt-components.src.components.mgt-get 22% 100% 0
mgt-components.src.components.mgt-messages 68% 100% 0
mgt-components.src.components.mgt-organization 47% 100% 0
mgt-components.src.components.mgt-person 79% 72% 0
mgt-components.src.components.mgt-person-card 50% 65% 0
mgt-components.src.components.mgt-picker 80% 100% 0
mgt-components.src.components.mgt-profile 40% 100% 0
mgt-components.src.components.mgt-tasks-base 87% 100% 0
mgt-components.src.components.mgt-theme-toggle 100% 100% 0
mgt-components.src.components.mgt-todo 79% 100% 0
mgt-components.src.components.sub-components.mgt-flyout 72% 53% 0
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0
mgt-components.src.graph 38% 78% 0
mgt-components.src.styles 92% 80% 0
mgt-components.src.utils 78% 12% 0
mgt-element.dist.es6.components.src.components 72% 73% 0
mgt-element.dist.es6.mock.src.mock 91% 73% 0
mgt-element.dist.es6.providers.src.providers 83% 69% 0
mgt-element.dist.es6.src 90% 100% 0
mgt-element.dist.es6.utils.src.utils 64% 76% 0
mgt-element.src 93% 40% 0
mgt-element.src.components 78% 100% 0
mgt-element.src.mock 81% 56% 0
mgt-element.src.providers 83% 91% 0
mgt-element.src.utils 71% 90% 0
Summary 64% (13766 / 21440) 66% (395 / 598) 0

Copy link

github-actions bot commented Feb 2, 2024

📖 The updated storybook is available here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] - Template lines of MGT-Person component no longer show ellipsis
4 participants