Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a useIsSignedIn custom hook for react #3093

Merged
merged 24 commits into from Mar 21, 2024
Merged

feat: add a useIsSignedIn custom hook for react #3093

merged 24 commits into from Mar 21, 2024

Conversation

musale
Copy link
Contributor

@musale musale commented Feb 28, 2024 •
edited

Closes #3083

PR Type

  • Feature

Description of the changes

  • Adds core functionality to check signed in state in mgt-element
  • Adds a custom hook function that wraps around the core functionality, setting the signed in state in mgt-react
  • Updated the README to show available custom hooks and the sample usage

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@musale musale requested a review from a team as a code owner February 28, 2024 10:34
@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

2 similar comments
@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

@sebastienlevert
Copy link
Contributor

@musale a docs PR would also be required for this issue to show case its use!

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback Issue needs response from issue author label Feb 28, 2024
@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback Issue needs response from issue author label Feb 29, 2024
@musale @gavinbarron
Update packages/mgt-element/src/utils/signedInState.tests.ts
e539418 
Co-authored-by: Gavin Barron <gavinbarron@microsoft.com>
@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

@sebastienlevert
Copy link
Contributor

It might be useful to add a story that would be heavily JS-based and would showcase how to use this capability in both React and JS?

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

🚀 New react-contoso sample application deployed here

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

📖 The updated storybook is available here

@gavinbarron
Copy link
Member

@musale you'll need to add a suppression to enable the .to.be.true style assertions as this is failing at the linting step at the moment

@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback Issue needs response from issue author label Mar 18, 2024
@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

@musale @gavinbarron
Refactor as ternary to avoid returning undefined
696bb6a 
Co-authored-by: Gavin Barron <gavinbarron@microsoft.com>
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback Issue needs response from issue author label Mar 21, 2024
@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

gavinbarron
gavinbarron approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @musale
I really appreciate you taking the time to ensure that we land a good quality deliverable here

@gavinbarron gavinbarron enabled auto-merge (squash) March 21, 2024 16:52
@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

@gavinbarron gavinbarron merged commit 1e695aa into main Mar 21, 2024
9 checks passed
@gavinbarron gavinbarron deleted the feat/signed-in-hook branch March 21, 2024 16:55
@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 86% 75% 0 ✔
mgt-components.src.components.mgt-contact 68% 83% 0 ➖
mgt-components.src.components.mgt-file 62% 100% 0 ➖
mgt-components.src.components.mgt-file-list 46% 100% 0 ❌
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 86% 0 ❌
mgt-components.src.components.mgt-get 22% 100% 0 ❌
mgt-components.src.components.mgt-messages 68% 100% 0 ➖
mgt-components.src.components.mgt-organization 47% 100% 0 ❌
mgt-components.src.components.mgt-person 82% 100% 0 ✔
mgt-components.src.components.mgt-person-card 77% 49% 0 ✔
mgt-components.src.components.mgt-picker 80% 100% 0 ✔
mgt-components.src.components.mgt-profile 40% 100% 0 ❌
mgt-components.src.components.mgt-tasks-base 87% 100% 0 ✔
mgt-components.src.components.mgt-theme-toggle 100% 100% 0 ✔
mgt-components.src.components.mgt-todo 79% 100% 0 ✔
mgt-components.src.components.sub-components.mgt-flyout 78% 53% 0 ✔
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0 ✔
mgt-components.src.graph 38% 78% 0 ❌
mgt-components.src.styles 92% 80% 0 ✔
mgt-components.src.utils 79% 27% 0 ✔
mgt-element.dist.es6.components.src.components 72% 73% 0 ➖
mgt-element.dist.es6.mock.src.mock 91% 77% 0 ✔
mgt-element.dist.es6.providers.src.providers 85% 76% 0 ✔
mgt-element.dist.es6.src 91% 80% 0 ✔
mgt-element.dist.es6.utils.src.utils 68% 71% 0 ➖
mgt-element.src 93% 40% 0 ✔
mgt-element.src.components 78% 100% 0 ✔
mgt-element.src.mock 86% 78% 0 ✔
mgt-element.src.providers 84% 100% 0 ✔
mgt-element.src.utils 72% 91% 0 ➖
Summary 68% (14566 / 21559) 75% (529 / 706) 0 ➖

@gavinbarron gavinbarron mentioned this pull request Mar 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinbarron gavinbarron gavinbarron approved these changes

Assignees
No one assigned
Labels
Build: React Contoso Build: Storybook
Projects
Graph Toolkit
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Add the isSignedIn hook to mgt-react
3 participants
@musale @sebastienlevert @gavinbarron