Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mgt-channel-picker icons tab behavior #3185

Merged
merged 2 commits into from
May 28, 2024
Merged

fix: mgt-channel-picker icons tab behavior #3185

merged 2 commits into from
May 28, 2024

Conversation

Mnickii
Copy link
Collaborator

@Mnickii Mnickii commented May 22, 2024 •
edited

Closes #3136

PR Type

Bugfix

Description of the changes

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@Mnickii Mnickii requested a review from a team as a code owner May 22, 2024 11:00
@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

1 similar comment
@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

@Mnickii
Copy link
Collaborator Author

Mnickii commented May 22, 2024

@Raisul123 @vagpt hello, please confirm that this fixes the tab behavior issue in mgt-channel-picker

musale
musale reviewed May 23, 2024
View reviewed changes
.storybook/manager.js Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 86% 75% 0 ✔
mgt-components.src.components.mgt-contact 68% 83% 0 ➖
mgt-components.src.components.mgt-file 62% 100% 0 ➖
mgt-components.src.components.mgt-file-list 46% 100% 0 ❌
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 86% 0 ❌
mgt-components.src.components.mgt-get 22% 100% 0 ❌
mgt-components.src.components.mgt-messages 68% 100% 0 ➖
mgt-components.src.components.mgt-organization 47% 100% 0 ❌
mgt-components.src.components.mgt-person 82% 100% 0 ✔
mgt-components.src.components.mgt-person-card 77% 49% 0 ✔
mgt-components.src.components.mgt-picker 80% 100% 0 ✔
mgt-components.src.components.mgt-profile 40% 100% 0 ❌
mgt-components.src.components.mgt-tasks-base 87% 100% 0 ✔
mgt-components.src.components.mgt-theme-toggle 100% 100% 0 ✔
mgt-components.src.components.mgt-todo 79% 100% 0 ✔
mgt-components.src.components.sub-components.mgt-flyout 78% 53% 0 ✔
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0 ✔
mgt-components.src.graph 38% 78% 0 ❌
mgt-components.src.styles 92% 80% 0 ✔
mgt-components.src.utils 79% 27% 0 ✔
mgt-element.dist.es6.components.src.components 72% 73% 0 ➖
mgt-element.dist.es6.mock.src.mock 91% 73% 0 ✔
mgt-element.dist.es6.providers.src.providers 85% 76% 0 ✔
mgt-element.dist.es6.src 91% 80% 0 ✔
mgt-element.dist.es6.utils.src.utils 68% 71% 0 ➖
mgt-element.src 93% 40% 0 ✔
mgt-element.src.components 78% 100% 0 ✔
mgt-element.src.mock 81% 56% 0 ✔
mgt-element.src.providers 84% 100% 0 ✔
mgt-element.src.utils 72% 91% 0 ➖
Summary 67% (14551 / 21559) 74% (519 / 699) 0 ➖

@Mnickii Mnickii requested a review from musale May 24, 2024 11:40
@musale
Copy link
Contributor

musale commented May 27, 2024

Ping @vagpt and @Raisul123 this is ready for review

@vagpt
Copy link
Collaborator

vagpt commented May 27, 2024

This issue is working fine on the URL provided above hence we are good to close this issue.

Untitled.video.-.Made.with.Clipchamp.21.mp4

@musale musale merged commit ef846d5 into main May 28, 2024
10 checks passed
@musale musale deleted the fix/bug-3136 branch May 28, 2024 09:04
@gavinbarron gavinbarron mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@musale musale musale approved these changes

Assignees
No one assigned
Labels
Build: Storybook
Projects
Graph Toolkit
Status: Shipped 🚀
Milestone
No milestone
3 participants
@Mnickii @musale @vagpt