Sets IsComposable=true for workbook* bound types
#585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baywet
approved these changes
Mar 5, 2024
|
I think we may have to revert this PR temporarily to deal with some infrastructure issues. The generation pipeline isn't able to push some yamls because of the size exceeding 100MB so we would need to resolve #184 first to enable git LFS if we are to go forward. Lemme know your thoughts here. |
andrueastman
added a commit
that referenced
this pull request
Mar 13, 2024
This reverts commit 580c195.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #582
remove-capability-annotationsandadd-innererror-descriptionin the XSL file will have to be changed toFalseandTruerespectively.bindparameterinstead ofbindingparameterin the CSDL for the respective APIs been updated. These affects both actions and functions of these APIs. The mistypedbindparameteris used in the XSL script so that a match is possible. When these have been resolved upstream, we shall make the necessary changes here as well. @marabooy are you able to help surface this to the relevant API owner(s)?IsComposable=truefor Kiota-based OpenApi generation. This is because the aftermath of this is an increase in the number of paths, which may potentially affect the PowerShell SDK. See below diffs for the expected change in the number of paths after this change goes out: