Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking[ GraphClientFactory #6

Closed
7 of 8 tasks
Tracked by #1
jobala opened this issue Oct 27, 2021 · 3 comments · Fixed by microsoft/kiota-http-go#24
Closed
7 of 8 tasks
Tracked by #1

[Tracking[ GraphClientFactory #6

jobala opened this issue Oct 27, 2021 · 3 comments · Fixed by microsoft/kiota-http-go#24
Assignees
Labels
enhancement New feature or request

Comments

@jobala
Copy link
Contributor

jobala commented Oct 27, 2021

  • Configure request timeout to 100secs
  • Configure connection timeout to 30secs
  • Allow users to pass their own HTTP client
  • Support attaching middleware pipeline to existing http client
  • Set sdk version header
  • Support custom hosts
  • Create instance of GraphClient with user defined middleware and default middleware
  • Create instance of GraphClient with default middleware
@baywet
Copy link
Member

baywet commented Nov 4, 2021

Thanks for the feedback on this one @jobala !
Some of the things have been addressed since you created this issue, so I took the liberty to check these off.
For others, that'd require more significant work, I created dedicated issues for them.
For sovereign cloud/custom hosts, we've had a discussion on the topic with @andrueastman here it's part of the planned changes in Kiota.

Would you mind taking on the time out configuration please?

@baywet baywet added the enhancement New feature or request label Nov 4, 2021
@baywet baywet added this to the Core specification alignment milestone Nov 4, 2021
@baywet
Copy link
Member

baywet commented Nov 4, 2021

PS: I believe the timeout configuration should live in Kiota http, not in this core directly.

@baywet baywet added the Standard GitHub label Issue caused by core project dependency modules or library label Nov 8, 2021
@baywet
Copy link
Member

baywet commented Nov 25, 2021

update: setting a custom host is not supported through requestAdapter.SetBaseUrl("https://thebaseurl")
Note: this needs to be set after passing the request adapter to a GraphServiceClient as the graph service client constructor also calls that method.

@jobala jobala removed the Standard GitHub label Issue caused by core project dependency modules or library label Jan 24, 2022
@jobala jobala self-assigned this Jan 24, 2022
@ddyett ddyett changed the title GraphClientFactory [Tracking[ GraphClientFactory Mar 16, 2022
@baywet baywet mentioned this issue Mar 17, 2022
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants