Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release workflow to trigger on tags for maven central releases #1978

Closed
5 of 6 tasks
baywet opened this issue May 2, 2024 · 1 comment · Fixed by #2025
Closed
5 of 6 tasks

Update release workflow to trigger on tags for maven central releases #1978

baywet opened this issue May 2, 2024 · 1 comment · Fixed by #2025
Assignees

Comments

@baywet
Copy link
Member

baywet commented May 2, 2024

The current workflow triggers on push to dev

branches: [dev, support/5.x.x]

if: ${{ github.ref == 'refs/heads/dev' || github.ref == 'refs/heads/support/5.x.x' }}

This is problematic because it creates more releases than we want.

TODO:

  • remove the trigger for the support branch (keep dev for snapshots)
  • add a trigger on tags v*
  • update the filter for central releases to check for tags only
  • remove approval on the maven central environment
  • replicate on beta
  • replicate on core
@baywet
Copy link
Member Author

baywet commented May 23, 2024

To recap what was said in teams and during meetings:
Before we can remove approval, we need to make sure releases are not going to go out inadvertly.
I suggested we add a filter to the maven central release job so we only consider tags created by the release please bot moving forward.
Once this is done, we can close this issue, and remove the approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants