Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout property of superagent library should be exposed #39

Closed
akramhussein opened this issue Apr 28, 2017 · 3 comments
Closed

Timeout property of superagent library should be exposed #39

akramhussein opened this issue Apr 28, 2017 · 3 comments
Assignees
Labels

Comments

@akramhussein
Copy link

Our testing experience has shown that intermittently the MSGraph can fail.

In our test-suite we've extended the time out of Mocha and this has resolved it, but we cannot do this in the main code as timeout property/method of superagent is not exposed.

Would it be possible to expose it as an option with a default perhaps?

@dan-silver dan-silver self-assigned this Apr 30, 2017
@dan-silver
Copy link
Contributor

dan-silver commented Apr 30, 2017

That's a great idea! We should support a library default, a client default set in MicrosoftGraph.Client.init, and a per call timeout method.

I can't guarantee when we can add the timeout property, but if you get to it first and submit a pull request I'm happy to review it.

2123527

@akramhussein
Copy link
Author

Hi @dan-silver - sounds good, I will take a look.

@muthurathinam
Copy link
Contributor

Fixed with this pull request and released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants