Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround non-deterministic order for registering syntactic sugar #187

Merged
merged 1 commit into from Aug 2, 2018

Conversation

cowboyd
Copy link
Member

@cowboyd cowboyd commented Aug 2, 2018

Because the list of syntax sugar is mutable and is appended to from different portions of the codebase, some sugars will not be registered in the right order.

This isn't a long-term fix for the issue, but it does resolve it in the short term.

Because the list of syntax sugar is mutable and is appended to from
different portions of the codebase, some sugars will not be registered
in the right order.

This isn't a long-term fix for the issue, but it does resolve it in
the short term.
@cowboyd
Copy link
Member Author

cowboyd commented Aug 2, 2018

There are still problems with the syntactic sugar, but now they can be worked around:

before:

class TodoList {
  todos = [Todo];
}

after:

class TodoList {
  todos = create([Todo]);
}

@cowboyd cowboyd merged commit 21a1ec9 into master Aug 2, 2018
@cowboyd cowboyd deleted the cl/hotfix-issue186-workaround branch August 2, 2018 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant