Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update badges to put best foot forward. #247

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Update badges to put best foot forward. #247

merged 1 commit into from
Oct 23, 2018

Conversation

cowboyd
Copy link
Member

@cowboyd cowboyd commented Oct 23, 2018

The coverage level is inaccurate, and reflects poorly on the project. In fact, we're not running coverage reports at all, and if we were, I have to imagine that the coverage level would be higher than 71%.

This change removes the coverage badge entirely until we actually commit to checking code coverage.

It also add adds an npm version badge so that it's clear which version is the current one.

Before

image

After

image

resolves #196

@taras
Copy link
Member

taras commented Oct 23, 2018

Let me get the actual coverage report values - if I can.

@taras taras mentioned this pull request Oct 23, 2018
@taras taras self-requested a review October 23, 2018 20:52
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.926% when pulling ad3f9b7 on cl/badge-update into 016aab3 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.926% when pulling ad3f9b7 on cl/badge-update into 016aab3 on master.

@coveralls
Copy link

coveralls commented Oct 23, 2018

Coverage Status

Coverage remained the same at 88.926% when pulling c1e9622 on cl/badge-update into 016aab3 on master.

Links to public npm package and released version.
@cowboyd cowboyd merged commit 60a373c into master Oct 23, 2018
@cowboyd cowboyd deleted the cl/badge-update branch October 23, 2018 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coverage not accurate
3 participants