Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSX Components #52

Closed
gtchakama opened this issue Feb 4, 2022 · 3 comments · Fixed by #53
Closed

JSX Components #52

gtchakama opened this issue Feb 4, 2022 · 3 comments · Fixed by #53

Comments

@gtchakama
Copy link

Can I please work on fixing some JSX components that don't have closing tags like the tags? They should be <img ...... />
@Microwawe
Copy link
Owner

Hi,

Yea absolutely! I'm not that familiar with React so any help finding/fixing those bugs is more than welcome.

Just to make sure that I understood the problem, plain HTML uses this syntax
<img ... >

and React needs the closing slash at the end?
<img ... />

@Microwawe
Copy link
Owner

If that's the case then looks like I'm just missing the handling for that in useReactSyntax() method in src/app/shared/services/formatter.service.ts

You can add that if you'd like (and please add a test case for it as well) or I can take a look during the weekend.

@gtchakama
Copy link
Author

Okay, will start working on it.

@Microwawe Microwawe linked a pull request Feb 9, 2022 that will close this issue
JSX bugs #53
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

JSX bugs Microwawe/mamba-ui
2 participants
@Microwawe @gtchakama