Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC support #309

Closed
onedr0p opened this issue Mar 19, 2023 · 10 comments · Fixed by #374
Closed

OIDC support #309

onedr0p opened this issue Mar 19, 2023 · 10 comments · Fixed by #374
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@onedr0p
Copy link
Contributor

onedr0p commented Mar 19, 2023

Hi 👋

It would be great if midarr supported OIDC so that I could use something like Authelia or Authentik to provide access to my existing managed friends and family.

@trueChazza trueChazza self-assigned this Mar 19, 2023
@trueChazza trueChazza added the enhancement New feature or request label Mar 19, 2023
@trueChazza trueChazza added this to the v3.1.0 milestone Mar 19, 2023
@trueChazza
Copy link
Member

Hi @onedr0p that sounds awesome! I've tagged this for the next minor release v3.1.0
I'll be in touch then - thanks!

@onedr0p
Copy link
Contributor Author

onedr0p commented Mar 19, 2023

I would mainly ask if these options could be configurable via env vars rather than in the UI. Thanks!

@trueChazza
Copy link
Member

Sounds good! I'll let you know when I've started working on this 😄

@onedr0p
Copy link
Contributor Author

onedr0p commented Mar 20, 2023

@trueChazza it might help understanding what env variables could be used to help drive the code. I was thinking these might be a good start.

OAUTH_ENABLED: "true"
OAUTH_ISSUER_URL: https://auth.domain.com/.well-known/openid-configuration
OAUTH_CLIENT_ID: "midarr"
OAUTH_CLIENT_SECRET: "some-random-text-string"
OAUTH_AUTO_REGISTER: "true"
OAUTH_BUTTON_TEXT: "Login with Authelia"

@trueChazza
Copy link
Member

Awesome, thanks for sending this through. This gives me a good base to start with 👍

@trueChazza
Copy link
Member

All good if I move this into release v3.2.0?

@trueChazza trueChazza modified the milestones: v3.1.0, v3.2.0 Apr 17, 2023
@trueChazza trueChazza linked a pull request May 17, 2023 that will close this issue
@trueChazza trueChazza modified the milestones: v3.2.0, v4.0.0 Jun 8, 2023
@trueChazza trueChazza linked a pull request Jun 27, 2023 that will close this issue
@trueChazza
Copy link
Member

@trueChazza it might help understanding what env variables could be used to help drive the code. I was thinking these might be a good start.

OAUTH_ENABLED: "true"
OAUTH_ISSUER_URL: https://auth.domain.com/.well-known/openid-configuration
OAUTH_CLIENT_ID: "midarr"
OAUTH_CLIENT_SECRET: "some-random-text-string"
OAUTH_AUTO_REGISTER: "true"
OAUTH_BUTTON_TEXT: "Login with Authelia"

@onedr0p Would you be keen to add the oauth button to the login page as you've described above?
So maybe show button when OAUTH_ENABLED: "true" and button text with OAUTH_BUTTON_TEXT: "Login with Authelia"

@trueChazza
Copy link
Member

@onedr0p Once I've merged #374 you could work off master for the oauth button.

@onedr0p
Copy link
Contributor Author

onedr0p commented Jul 11, 2023

I'll give it a shot when I have time 👍🏼 but I don't have a dev env for elixir set up or much experience around the tooling.

@trueChazza
Copy link
Member

https://github.com/midarrlabs/midarr-server#local-development

You should be able to just docker-compose up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants