Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to embed JS and CSS inline #4

Closed
janwalther opened this issue Apr 28, 2017 · 1 comment
Closed

Option to embed JS and CSS inline #4

janwalther opened this issue Apr 28, 2017 · 1 comment

Comments

@janwalther
Copy link

janwalther commented Apr 28, 2017

In my setup the webserver allows public access only to the folder where the front controller is located in (/var/www/html/public). When trying to use the debugbar it tries to embed JS and CSS files:

<link rel="stylesheet" type="text/css" href="/vendor/maximebf/debugbar/src/DebugBar/Resources/openhandler.css">
<script type="text/javascript" src="/vendor/maximebf/debugbar/src/DebugBar/Resources/vendor/jquery/dist/jquery.min.js"></script>

The problem is that the vendor folder is not publicly accessible (for security reasons) and thus those CSS and JS files cannot be loaded. That is why I would appreciate a setting to embed JS and CSS code inline.
This is possible by using $renderer->dumpJSAssets() and $renderer->dumpCSSAssets().

@janwalther
Copy link
Author

I created a PR so we can discuss the issue there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant