Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PHP 8 #22

Closed
arokettu opened this issue Nov 24, 2020 · 3 comments · Fixed by #23
Closed

Support PHP 8 #22

arokettu opened this issue Nov 24, 2020 · 3 comments · Fixed by #23

Comments

@arokettu
Copy link

Tests seem to pass but dev dependencies need to be reviewed

@oscarotero
Copy link
Member

Hi, thanks for the warning.
I don't have PHP8 installed in my computer yet, so I cannot test it. If you want to work in a pull request, it would be great. If not, don't worry, I'll fix it.
Thanks.

@arokettu
Copy link
Author

I don't want to work here because it involves decisions that involve maintainer's comfort

Here is the list of blockers after upgrade of outdated libraries:

$ composer why-not php 8                
friendsofphp/php-cs-fixer       v2.16.7     requires  php (^7.1)  
guzzlehttp/psr7                 2.0.x-dev   requires  php (^7.2)  
oscarotero/php-cs-fixer-config  v1.0.1      requires  php (^7.2)  
slim/psr7                       1.2.0       requires  php (^7.2)  
sunrise/http-header             v1.0.9      requires  php (^7.1)  
sunrise/http-message            v1.3.0      requires  php (^7.1)  
sunrise/http-server-request     v1.0.12     requires  php (^7.1)  
sunrise/stream                  v1.0.21     requires  php (^7.1)  
sunrise/uri                     v1.1.0      requires  php (^7.1)

Here is my pr for whoops: middlewares/whoops#9

@oscarotero
Copy link
Member

Ok, understood. Those are all dev dependencies, so I think it should be easy to fix. I'll work on that.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants