New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CORS middleware to support other CORS headers #43
Comments
@lmammino can I work on this? |
Sure thing @akshitgrover |
can i work on this |
@akshitgrover, what's the current status? Do you want to coordinate/pair with @abdullateef97? |
please do let me know if i can proceed |
@lmammino can i |
@abdullateef97 go ahead for now ;) |
Sorry, I was stuck with something. Maybe I can help if work is still not done? @lmammino @abdullateef97 |
I would be happy for this to be a collaborative effort between @akshitgrover and @abdullateef97 . Can you discuss this between yourself and figure out how to collaborate? If you need a discussion channel, you can join the middy official chat on gitter: https://gitter.im/middyjs . Once you have a first PR, I will be happy to support the process with a formal reviews and advices if needed. |
I am working on Access-Control-Max-Age. @lmammino @abdullateef97 |
@lmammino ive u tried using the cors middleware, if you have what were the issues |
@lmammino I am not able to run the tests, It is not returning undefined instead of objects. |
@abdullateef97 @akshitgrover I am not sure what are you trying to do. Please join the gitter chat where I guess it would be easier to discuss interactively your issues. |
@lmammino - Are you going to add the following any time soon?
|
I see this issue is closed but there is no solution yet if you want to be able to set the |
It's been added to v2, see |
It would be great to have support to other common CORS headers like the follows:
Access-Control-Allow-Methods
Access-Control-Allow-Headers
Access-Control-Max-Age
Access-Control-Allow-Credentials
More info here
The text was updated successfully, but these errors were encountered: