Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for service: loadBalancer for Unifi chart #67

Open
mddeff opened this issue Sep 6, 2023 · 2 comments · May be fixed by #68
Open

Adding support for service: loadBalancer for Unifi chart #67

mddeff opened this issue Sep 6, 2023 · 2 comments · May be fixed by #68
Assignees
@duhow

Comments

@mddeff
Copy link

mddeff commented Sep 6, 2023

Hey, would there be any objection to merging in a change that allows for support for service of type LoadBalancer for the Ubiquity Unifi controller chart? Being able to expose all of the endpoints can be useful in several environments.

Example change. Any PR would include everything variable-ized and bubbled up to the main chart values.yaml.

Thoughts?
@duhow duhow self-assigned this Sep 6, 2023
@duhow duhow linked a pull request Sep 19, 2023 that will close this issue
Open
@duhow
Copy link
Contributor

duhow commented Sep 19, 2023

Have a look at PR and let me know if that works for you?

@mddeff
Copy link
Author

mddeff commented Oct 28, 2023

@duhow Sorry for the delay at looking at this, thank you for putting that together! I'll take it for a spin this week and make sure it works as expected but it looks like on the surface it should do the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duhow duhow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[unifi-controller] Support Service LoadBalancer midokura/helm-charts-community
2 participants
@duhow @mddeff