Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require MRI >= 2.5 & update Gemfile #174

Closed
wants to merge 1 commit into from
Closed

Require MRI >= 2.5 & update Gemfile #174

wants to merge 1 commit into from

Conversation

jasl
Copy link
Collaborator

@jasl jasl commented Jul 28, 2019

  • Set minimal MRI requirement to 2.5, because 2.3 EOL & 2.4 EOL soon
  • Update rubocop.yml (from my personal based on Rails'), current can't run on latest Rubocop
  • Restructure Gemfile and midori.gemspec

@jasl
Copy link
Collaborator Author

jasl commented Jul 28, 2019

Test will hang at Midori::Runner - should not stop before started on my macOS 10.14.6 because EventLoop.deregister @server hanging, I think we need to adding a hard timeout

@jasl jasl marked this pull request as ready for review July 30, 2019 14:11
@jasl jasl force-pushed the upgrade-deps branch 5 times, most recently from 271604c to 6b6c661 Compare July 30, 2019 15:18
@dsh0416 dsh0416 closed this Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jasl @dsh0416