Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome-terminal only #18

Closed
Kidlike opened this issue Jan 24, 2023 · 4 comments
Closed

gnome-terminal only #18

Kidlike opened this issue Jan 24, 2023 · 4 comments

Comments

@Kidlike
Copy link

Kidlike commented Jan 24, 2023

const commands = [`gnome-terminal -- ${simulatorPath} ${args.join(" ")}`];

could this become configurable?

@midouest
Copy link
Owner

Good idea!

@Kidlike
Copy link
Author

Kidlike commented Jan 24, 2023

fyi, I had to slightly change syntax for konsole. it has to be like konsole -e /bin/bash -c <...> instead of gnome-terminal -- <...>. Not sure how to handle this properly with config... maybe something like command prefix 🤷‍♂️

@midouest
Copy link
Owner

Good to know. Something simple like a prefix is probably the way to go.

I’m hoping to rework the whole Linux code path once debugging is supported. Launching the Simulator from a gnome-terminal is a workaround for an issue I encountered when I attempted to launch it as a detached child process.

@midouest
Copy link
Owner

midouest commented Feb 11, 2023

I've just published version 1.13 of the extension as a pre-release. It should be available on the marketplace any minute! 🤞 Let me know if the new changes work for you!

The simulator will now launch in VSCode's integrated terminal instead of a Gnome terminal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants