Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout to tooltip after few seconds to remove it #103

Open
diegogb-08 opened this issue Oct 3, 2021 · 6 comments
Open

Add timeout to tooltip after few seconds to remove it #103

diegogb-08 opened this issue Oct 3, 2021 · 6 comments

Comments

@diegogb-08
Copy link
Contributor

When you hover the sidebar buttons, the tooltip stays there as long as you have the mouse over, but I think it would be better if the tooltip disappear after 5 seconds

@diegogb-08
Copy link
Contributor Author

I have opened a PR to fix this issue: #104 I hope you like it. This is actually my first PR ever in an open source project :)

@dartilesm
Copy link
Contributor

When you hover the sidebar buttons, the tooltip stays there as long as you have the mouse over, but I think it would be better if the tooltip disappear after 5 seconds

Hi @diegogb-08 , why do you think that is wrong? I think it is the normal behavior of tooltips. In fact, in visual studio, it does not disappear until the cursor leaves the element.
vscode

I have opened a PR to fix this issue: #104 I hope you like it. This is actually my first PR ever in an open source project :)

It's also my first time collaborating on open source projects. Congrats!!

@diegogb-08
Copy link
Contributor Author

Actually you are right, even though my vscode does not act the same way you show on the video. However, I still think that it is a bit annoying to have the tooltip there forever and I think the fact that it disappears or appears after few seconds gives a better UX because it is not covering forever part of text from the menu. It might be me with my OCD :).

@stylessh
Copy link

stylessh commented Oct 5, 2021

It's not a critical requested feature, but it helps to the experience anyway. Let's see if it got accepted!

@QuevedoIB
Copy link
Contributor

In my opinion we shouldn't remove tooltips, as @dartilesm pointed, vscode doesn't remove them till element isn't hovered. They copy title attribute behaviour and in terms of user experience is better to leave it like that. (Just my point of view)

@midudev
Copy link
Owner

midudev commented Oct 7, 2021

I would recommend to hide the tooltip actually when the user click in the section and enters. Some changes to the PR would be needed, as now the tooltip is being hidden even when you're only hovering the button.

This way, we mimic the VSCode functionality as well. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants