Skip to content
This repository has been archived by the owner on Jul 2, 2020. It is now read-only.

fix: fix send json when fc use http trigger #155

Merged
merged 2 commits into from
May 5, 2020
Merged

Conversation

czy88840616
Copy link
Member

@czy88840616 czy88840616 commented May 5, 2020

if we use res.send(json) in http trigger, fc will be throw error.

TypeError: buffer should be a Buffer or a string or a stream.Readable

@gitpod-io
Copy link

gitpod-io bot commented May 5, 2020

@codecov-io
Copy link

codecov-io commented May 5, 2020

Codecov Report

Merging #155 into master will not change coverage.
The diff coverage is 54.54%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #155   +/-   ##
=======================================
  Coverage   80.28%   80.28%           
=======================================
  Files          85       85           
  Lines        3181     3181           
  Branches      357      357           
=======================================
  Hits         2554     2554           
  Misses        623      623           
  Partials        4        4           
Impacted Files Coverage Δ
packages/serverless-fc-starter/src/runtime.ts 85.71% <54.54%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69f82cc...deb11bd. Read the comment docs.

@czy88840616 czy88840616 merged commit 1e9abc4 into master May 5, 2020
@czy88840616 czy88840616 deleted the fix_http_json_body branch May 5, 2020 08:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants