Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: component env filter #1234

Merged
merged 2 commits into from
Aug 18, 2021
Merged

fix: component env filter #1234

merged 2 commits into from
Aug 18, 2021

Conversation

czy88840616
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@gitpod-io
Copy link

gitpod-io bot commented Aug 17, 2021

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2021

Codecov Report

Merging #1234 (35a76b9) into 2.x (1d20d64) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              2.x    #1234   +/-   ##
=======================================
  Coverage   85.28%   85.29%           
=======================================
  Files         236      236           
  Lines        9181     9186    +5     
  Branches     1741     1745    +4     
=======================================
+ Hits         7830     7835    +5     
  Misses       1279     1279           
  Partials       72       72           
Impacted Files Coverage Δ
packages/core/src/interface.ts 100.00% <ø> (ø)
packages/task/src/config/config.default.ts 100.00% <ø> (ø)
packages-serverless/egg-layer/index.js 87.09% <100.00%> (+0.21%) ⬆️
packages/core/src/baseFramework.ts 94.59% <100.00%> (+0.02%) ⬆️
packages/core/src/service/aspectService.ts 91.96% <100.00%> (+0.14%) ⬆️
packages/task/src/configuration.ts 89.71% <100.00%> (+0.09%) ⬆️
packages/ws/src/framework.ts 92.30% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c826e68...35a76b9. Read the comment docs.

@czy88840616 czy88840616 merged commit bfb44b7 into 2.x Aug 18, 2021
@czy88840616 czy88840616 deleted the fix_env_load branch August 18, 2021 02:58
czy88840616 added a commit that referenced this pull request Aug 28, 2021
* fix: component env filter

* fix: jest version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants