Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: faas missing config in framework #1413

Merged
merged 6 commits into from Dec 9, 2021
Merged

fix: faas missing config in framework #1413

merged 6 commits into from Dec 9, 2021

Conversation

czy88840616
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@gitpod-io
Copy link

gitpod-io bot commented Dec 8, 2021

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2021

Codecov Report

Merging #1413 (d13837b) into 3.x (bfafbdf) will increase coverage by 0.02%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.x    #1413      +/-   ##
==========================================
+ Coverage   82.00%   82.02%   +0.02%     
==========================================
  Files         314      314              
  Lines       10706    10717      +11     
  Branches     2292     2298       +6     
==========================================
+ Hits         8779     8791      +12     
+ Misses       1806     1805       -1     
  Partials      121      121              
Impacted Files Coverage Δ
packages-serverless/egg-layer/index.js 83.95% <ø> (ø)
packages/core/src/interface.ts 100.00% <ø> (ø)
...es/decorator/src/decorator/common/configuration.ts 100.00% <ø> (ø)
packages/core/src/common/webRouterCollector.ts 98.35% <66.66%> (-0.54%) ⬇️
packages/core/src/context/container.ts 92.36% <100.00%> (+0.08%) ⬆️
packages/core/src/setup.ts 91.17% <100.00%> (+1.94%) ⬆️
packages/faas/src/configuration.ts 92.30% <100.00%> (+0.30%) ⬆️
packages/faas/src/framework.ts 76.47% <100.00%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfafbdf...d13837b. Read the comment docs.

@czy88840616 czy88840616 merged commit 7ab16a2 into 3.x Dec 9, 2021
@czy88840616 czy88840616 deleted the fix_faas_run branch December 9, 2021 09:25
@czy88840616 czy88840616 mentioned this pull request Dec 12, 2021
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants