Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not found after no router set. #1698

Merged
merged 1 commit into from Feb 13, 2022

Conversation

czy88840616
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@gitpod-io
Copy link

gitpod-io bot commented Feb 13, 2022

@czy88840616 czy88840616 changed the title fix: not found after not router set. fix: not found after no router set. Feb 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2022

Codecov Report

Merging #1698 (27cc7ae) into main (c17f049) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1698      +/-   ##
==========================================
+ Coverage   82.05%   82.15%   +0.10%     
==========================================
  Files         388      388              
  Lines       12836    12883      +47     
  Branches     2973     2979       +6     
==========================================
+ Hits        10532    10584      +52     
+ Misses       2112     2107       -5     
  Partials      192      192              
Impacted Files Coverage Δ
packages/web-express/src/framework.ts 78.70% <100.00%> (ø)
packages/web-koa/src/framework.ts 72.16% <100.00%> (ø)
packages/web-koa/src/onerror.ts 54.63% <100.00%> (ø)
packages/web/src/framework/web.ts 82.51% <100.00%> (ø)
packages/task/src/configuration.ts 100.00% <0.00%> (ø)
packages/task/src/framework.ts 93.75% <0.00%> (+7.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c17f049...27cc7ae. Read the comment docs.

@czy88840616 czy88840616 merged commit c7f466f into main Feb 13, 2022
@czy88840616 czy88840616 deleted the fix_midddleware_set_body_no_router branch February 13, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants