Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ctx.getLogger does not overwrite success #1908

Merged
merged 1 commit into from Apr 14, 2022
Merged

Conversation

czy88840616
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@gitpod-io
Copy link

gitpod-io bot commented Apr 14, 2022

@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2022

Codecov Report

Merging #1908 (09fad5c) into main (2c7c235) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1908      +/-   ##
==========================================
- Coverage   82.11%   82.10%   -0.02%     
==========================================
  Files         403      403              
  Lines       13437    13439       +2     
  Branches     3124     3124              
==========================================
  Hits        11034    11034              
- Misses       2201     2203       +2     
  Partials      202      202              
Impacted Files Coverage Δ
packages/web/app/extend/context.js 78.26% <0.00%> (-7.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7dac7f...09fad5c. Read the comment docs.

@czy88840616 czy88840616 merged commit 5fcb1c6 into main Apr 14, 2022
@czy88840616 czy88840616 deleted the fix_ctx_logger branch April 14, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants