Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add context manager with middleware #2116

Merged
merged 7 commits into from
Jul 14, 2022
Merged

Conversation

czy88840616
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@gitpod-io
Copy link

gitpod-io bot commented Jul 12, 2022

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2022

Codecov Report

Merging #2116 (2f03962) into main (0f6b34e) will decrease coverage by 0.03%.
The diff coverage is 92.18%.

❗ Current head 2f03962 differs from pull request most recent head fbd0751. Consider uploading reports for the commit fbd0751 to get more accurate results

@@            Coverage Diff             @@
##             main    #2116      +/-   ##
==========================================
- Coverage   82.26%   82.23%   -0.04%     
==========================================
  Files         426      428       +2     
  Lines       14767    14830      +63     
  Branches     3512     3519       +7     
==========================================
+ Hits        12148    12195      +47     
- Misses       2397     2412      +15     
- Partials      222      223       +1     
Impacted Files Coverage Δ
packages/core/src/baseFramework.ts 85.71% <84.61%> (+0.30%) ⬆️
packages/core/src/util/asyncContextManager.ts 87.50% <87.50%> (ø)
packages/async-hooks-context-manager/src/index.ts 100.00% <100.00%> (ø)
packages/core/src/config/config.default.ts 100.00% <100.00%> (ø)
packages/core/src/index.ts 100.00% <100.00%> (ø)
packages/core/src/interface.ts 100.00% <100.00%> (ø)
packages/decorator/src/util/uuid.ts 45.00% <0.00%> (-55.00%) ⬇️
packages/faas/src/framework.ts 77.20% <0.00%> (-0.45%) ⬇️
packages/web-express/src/framework.ts 77.45% <0.00%> (+0.26%) ⬆️
packages/web-koa/src/framework.ts 73.78% <0.00%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f4f0cd...fbd0751. Read the comment docs.

@czy88840616 czy88840616 merged commit 99ba506 into main Jul 14, 2022
@czy88840616 czy88840616 deleted the support_context_manager branch July 14, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants