Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unexpected token 'export' in load **.d.ts file in prod mode #2185

Merged
merged 1 commit into from Aug 1, 2022

Conversation

liaojiankai
Copy link
Contributor

@liaojiankai liaojiankai commented Aug 1, 2022

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@gitpod-io
Copy link

gitpod-io bot commented Aug 1, 2022

@@ -8,7 +8,7 @@ import { join } from 'path';
import { Types } from '@midwayjs/decorator';

const DEFAULT_PATTERN = ['**/**.ts', '**/**.js'];

const IGNORE_PATTERN = ['**/**.d.ts'];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以考虑加上 .d.mts, .d.cts 这两个后缀

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加个 test 吧

@codecov-commenter
Copy link

Codecov Report

Merging #2185 (9f95a1b) into main (3668748) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2185      +/-   ##
==========================================
- Coverage   82.08%   81.96%   -0.13%     
==========================================
  Files         433      433              
  Lines       15190    15191       +1     
  Branches     3590     3590              
==========================================
- Hits        12469    12451      -18     
- Misses       2487     2503      +16     
- Partials      234      237       +3     
Impacted Files Coverage Δ
packages/core/src/common/dataSourceManager.ts 100.00% <100.00%> (ø)
packages/oss/src/manager.ts 38.88% <0.00%> (-50.00%) ⬇️
packages/oss/src/configuration.ts 60.00% <0.00%> (-40.00%) ⬇️
packages/upload/src/parse.ts 93.70% <0.00%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3668748...9f95a1b. Read the comment docs.

@czy88840616 czy88840616 merged commit 6d634ce into midwayjs:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants