Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: service factory client & clients merge #2248

Merged
merged 6 commits into from
Aug 20, 2022
Merged

Conversation

czy88840616
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@gitpod-io
Copy link

gitpod-io bot commented Aug 17, 2022

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2022

Codecov Report

Merging #2248 (a794dfa) into main (942dd07) will increase coverage by 0.16%.
The diff coverage is 81.25%.

@@            Coverage Diff             @@
##             main    #2248      +/-   ##
==========================================
+ Coverage   82.51%   82.68%   +0.16%     
==========================================
  Files         434      434              
  Lines       15240    15262      +22     
  Branches     3606     3617      +11     
==========================================
+ Hits        12576    12619      +43     
+ Misses       2437     2414      -23     
- Partials      227      229       +2     
Impacted Files Coverage Δ
packages/cos/src/manager.ts 52.17% <33.33%> (-4.97%) ⬇️
packages/core/src/service/configService.ts 97.01% <60.00%> (+1.63%) ⬆️
packages/axios/src/serviceManager.ts 85.00% <66.66%> (-9.74%) ⬇️
packages/oss/src/manager.ts 85.00% <80.00%> (-3.89%) ⬇️
packages/axios/src/configuration.ts 100.00% <100.00%> (ø)
packages/core/src/common/serviceFactory.ts 86.20% <100.00%> (-0.46%) ⬇️
packages/mongoose/src/manager.ts 65.30% <100.00%> (+1.47%) ⬆️
packages/redis/src/manager.ts 69.64% <100.00%> (-2.58%) ⬇️
packages/tablestore/src/manager.ts 100.00% <100.00%> (ø)
packages/decorator/src/util/uuid.ts 45.00% <0.00%> (-55.00%) ⬇️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@czy88840616 czy88840616 merged commit cfdee64 into main Aug 20, 2022
@czy88840616 czy88840616 deleted the support_axios_clients branch August 20, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants