Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run stop lifecycle with reverse #2626

Merged
merged 2 commits into from Jan 26, 2023
Merged

fix: run stop lifecycle with reverse #2626

merged 2 commits into from Jan 26, 2023

Conversation

czy88840616
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@czy88840616 czy88840616 changed the title Fix stop reverse fix: run stop lifecycle with reverse Jan 3, 2023
@czy88840616 czy88840616 added the pr: bug fix This PR fixes a bug in a past release. label Jan 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2023

Codecov Report

Base: 81.92% // Head: 81.95% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (eb1ff6a) compared to base (f14cbf5).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2626      +/-   ##
==========================================
+ Coverage   81.92%   81.95%   +0.02%     
==========================================
  Files         414      414              
  Lines       14687    14687              
  Branches     3465     3466       +1     
==========================================
+ Hits        12033    12037       +4     
+ Misses       2408     2404       -4     
  Partials      246      246              
Impacted Files Coverage Δ
packages/core/src/service/lifeCycleService.ts 98.30% <100.00%> (ø)
packages/core/src/context/container.ts 94.96% <0.00%> (+0.62%) ⬆️
packages/bootstrap/src/util.ts 90.32% <0.00%> (+6.45%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@czy88840616 czy88840616 merged commit 2490c60 into main Jan 26, 2023
@czy88840616 czy88840616 deleted the fix_stop_reverse branch January 26, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: bug fix This PR fixes a bug in a past release.
Development

Successfully merging this pull request may close these issues.

None yet

2 participants