Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: global middleware can't catch error #542

Merged
merged 4 commits into from
Jul 27, 2020
Merged

fix: global middleware can't catch error #542

merged 4 commits into from
Jul 27, 2020

Conversation

czy88840616
Copy link
Member

@czy88840616 czy88840616 commented Jul 18, 2020 •
edited
Loading

Close #543

@gitpod-io
Copy link

gitpod-io bot commented Jul 18, 2020 •
edited
Loading

@czy88840616 czy88840616 linked an issue Jul 18, 2020 that may be closed by this pull request
faas 全局中间件无法正确进入 catch #543
Closed
@czy88840616 czy88840616 changed the title Fix global err fix: global middleware can't catch error Jul 18, 2020
Lellansin
Lellansin approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@Lellansin Lellansin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@czy88840616 czy88840616 merged commit 8892471 into serverless Jul 27, 2020
@czy88840616 czy88840616 deleted the fix_global_err branch July 27, 2020 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lellansin Lellansin Lellansin approved these changes

@echosoar echosoar Awaiting requested review from echosoar

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

faas 全局中间件无法正确进入 catch
2 participants
@czy88840616 @Lellansin