Introduce a generic slice clone function #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is nil-preserving unlike the existing code. We also add some missing []byte slice copies.
|
The go.mod / go.sum changes come from bumping the go version and running |
miekg
approved these changes
Mar 12, 2023
tmthrgd
added a commit
to tmthrgd/miekgdns
that referenced
this pull request
Nov 6, 2023
I missed this pattern in miekg#1432. These seem to be the only two occurrences. Updates miekg#1432
miekg
pushed a commit
that referenced
this pull request
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is nil-preserving unlike the existing code.
We also add some missing []byte slice copies.
Fixes #1381