Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to LOC type RFC1876 #1440

Merged
merged 1 commit into from Mar 18, 2023
Merged

Updates to LOC type RFC1876 #1440

merged 1 commit into from Mar 18, 2023

Conversation

systemcrash
Copy link
Contributor

miekg
miekg reviewed Mar 16, 2023
View reviewed changes
types.go Show resolved Hide resolved
tmthrgd
tmthrgd requested changes Mar 16, 2023
View reviewed changes
Copy link
Collaborator

@tmthrgd tmthrgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits.

types_test.go Outdated Show resolved Hide resolved
types.go Outdated Show resolved Hide resolved
tmthrgd
tmthrgd approved these changes Mar 17, 2023
View reviewed changes
Copy link
Collaborator

@tmthrgd tmthrgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@miekg miekg merged commit 800bb6f into miekg:master Mar 18, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miekg miekg miekg left review comments

@tmthrgd tmthrgd tmthrgd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@systemcrash @tmthrgd @miekg