Fix some lint checks by (go) staticcheck ./...

[systemcrash]

Minimally invasive, identical behaviour.

Some warn about deprecation.

There are a few more which require some more thought.

[tmthrgd]

Thanks. A few changes though.

[tmthrgd]

Would you mind adding the entire output of staticcheck as comment just for reference?

[systemcrash]

Before PR

clientconfig_test.go:4:2: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details.  (SA1019)
dnssec.go:131:6: func divRoundUp is unused (U1000)
dnssec.go:421:2: empty branch (SA9003)
generate_test.go:5:2: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details.  (SA1019)
msg.go:873:2: empty branch (SA9003)
msg_helpers_test.go:437:8: use net.IP.Equal to compare net.IPs, not bytes.Equal (SA1021)
msg_helpers_test.go:586:7: use net.IP.Equal to compare net.IPs, not bytes.Equal (SA1021)
parse_test.go:234:6: func testTXTRRQuick is unused (U1000)
scan_test.go:5:2: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details.  (SA1019)
server.go:462:44: neterr.Temporary has been deprecated since Go 1.18 because it shouldn't be used: Temporary errors are not well-defined. Most "temporary" errors are timeouts, and the few exceptions are surprising. Do not use this method.  (SA1019)
server.go:521:44: netErr.Temporary has been deprecated since Go 1.18 because it shouldn't be used: Temporary errors are not well-defined. Most "temporary" errors are timeouts, and the few exceptions are surprising. Do not use this method.  (SA1019)
server.go:528:21: argument should be pointer-like to avoid allocations (SA6002)
server.go:640:20: argument should be pointer-like to avoid allocations (SA6002)
server.go:656:19: argument should be pointer-like to avoid allocations (SA6002)
server.go:697:19: argument should be pointer-like to avoid allocations (SA6002)
server.go:715:19: argument should be pointer-like to avoid allocations (SA6002)

After

server.go:462:44: neterr.Temporary has been deprecated since Go 1.18 because it shouldn't be used: Temporary errors are not well-defined. Most "temporary" errors are timeouts, and the few exceptions are surprising. Do not use this method.  (SA1019)
server.go:521:44: netErr.Temporary has been deprecated since Go 1.18 because it shouldn't be used: Temporary errors are not well-defined. Most "temporary" errors are timeouts, and the few exceptions are surprising. Do not use this method.  (SA1019)
server.go:528:21: argument should be pointer-like to avoid allocations (SA6002)
server.go:640:20: argument should be pointer-like to avoid allocations (SA6002)
server.go:656:19: argument should be pointer-like to avoid allocations (SA6002)
server.go:697:19: argument should be pointer-like to avoid allocations (SA6002)
server.go:715:19: argument should be pointer-like to avoid allocations (SA6002)

[tmthrgd]

One last nit.

[systemcrash]

One last nit.

msg.go:863:3: this value of off is never used (SA4006)

[tmthrgd]

Okay that was missed out of the comment above. Yeah sure add the off -> _ change back in.

Quick thing though, please don't force push as it messes up our ability to review PRs. Just add new commits to the branch.

[tmthrgd]

LGTM.